Prevent buffer overrun on NGX_HTTP_REQUEST_HEADER_TOO_LARGE

Maxim Dounin mdounin at
Wed Oct 8 13:45:17 UTC 2014


On Tue, Oct 07, 2014 at 07:11:24PM +0000, Bondarev, Daniil wrote:

> Hey Maxim,
> > On the other hand, looking into this more closely, I tend to think
> > that ellipsis should be always added to make it clear that the
> > header logged is incomplete.
> Agree, good point! 
> Patch looks good to me, only note - you can reduce amount of lines by ngx_min,
> if you wish:

I think the code is more readable as is, without ngx_min().
The patch comitted, thanks.

Maxim Dounin

More information about the nginx-devel mailing list