[PATCH] Contrib: add more directives to vim syntax

Maxim Dounin mdounin at mdounin.ru
Wed Oct 22 06:04:45 UTC 2014


On Sun, Oct 19, 2014 at 04:21:23PM +0200, Peter Wu wrote:

> Hi,
> While editing a config file I noticed that ssl_stapling was not highlighted.
> Please find the attached patch to update the directives in the vim syntax
> highlighting file.

Thanks, it needs refreshing.

> The script to extract all directives is also attached. I also compared the
> output against the list on http://nginx.org/en/docs/dirindex.html and noticed
> that some directives are missing on that page,

Some directives are undocumented on purpose.  E.g., acceptex_read 
directive you've added in your patch is from never worked 
unfinished acceptex event handling module.

> and that some typos are present
> (for example, fascgi_force_ranges instead of "fastcgi_force_ranges").

This means there is a typo in the directive name in docs.  This on 
fixed, thanks:


(BTW, patches for docs are also welcome.)

> # HG changeset patch
> # User Peter Wu <peter at lekensteyn.nl>
> # Date 1413727713 -7200
> #      Sun Oct 19 16:08:33 2014 +0200
> # Node ID 052ec6744ffb2cce94c312a8a62d3ddc650dfe7d
> # Parent  973fded4f461f3a397779b3a1dc80881b1b34974
> Contrib: add more directives to vim syntax

Please add a trailing dot here.

> uwsgi is not a third-party module anymore. 'split_clients' is a new
> block directive type. The directives have automatically been extracted
> from ngx_command_t arrays and are manually reviewed.
> Trailing spaces got removed at some places.
> Also mention an alternative path for the vim syntax files (which is in
> use on Arch Linux).
> diff -r 973fded4f461 -r 052ec6744ffb contrib/README
> --- a/contrib/README	Wed Oct 15 22:57:23 2014 +0400
> +++ b/contrib/README	Sun Oct 19 16:08:33 2014 +0200
> @@ -17,5 +17,5 @@ unicode2nginx		by Maxim Dounin
>  vim			by Evan Miller
>  	Syntax highlighting of nginx configuration for vim, to be
> -	placed into ~/.vim/.
> +	placed into ~/.vim/ or /usr/share/vim/vimfiles/.

I would like to avoid platform-specific paths here.


>  syn keyword ngxDirective epoll_events
>  syn keyword ngxDirective error_log
> +syn keyword ngxDirective error_log

We probably don't wont duplicate directives here and in other 

> +syn keyword ngxDirective etag
>  syn keyword ngxDirective eventport_events
>  syn keyword ngxDirective expires
>  syn keyword ngxDirective fastcgi_bind
> +syn keyword ngxDirective fastcgi_buffering
> +syn keyword ngxDirective fastcgi_buffers
>  syn keyword ngxDirective fastcgi_buffer_size
> -syn keyword ngxDirective fastcgi_buffers

The change in order looks strange, in lowercase 
fastcgi_buffer_size should be before fastcgi_buffers and 


Maxim Dounin

More information about the nginx-devel mailing list