[PATCH] Clarify meaning of limit_conn in SPDY connections

Yaroslav Zhuravlev yar at nginx.com
Thu Oct 30 19:03:09 UTC 2014


On 14 Oct 2014, at 20:58, Gunnlaugur Thor Briem <gunnlaugur at gmail.com> wrote:

> # HG changeset patch
> # User Gunnlaugur Thor Briem <gunnlaugur at gmail.com>
> # Date 1413305660 0
> #      Tue Oct 14 16:54:20 2014 +0000
> # Node ID 3674e10a9e22a622998b65badfe01da34579bb65
> # Parent  2096ecf6de02bc9e8ae920c45c59bf6a4e2e38fb
> Clarify meaning of limit_conn in SPDY connections
> 
> Be clear about limit_conn applying to concurrent requests, not connections.
> The distinction matters for SPDY connections.
> 

[…]

Hi Gunnlaugur!

Thank you for your patch. I wouldn’t change “connections” to "requests” because it is already reflected in the module description:

"Not all connections are counted. A connection is counted only if it has a request processed by the server and the whole request header has already been read.”

However, The part about SPDY was committed with some changes:

http://nginx.org/en/docs/http/ngx_http_limit_conn_module.html#limit_conn


Best regards, 
Yaroslav Zhuravlev


More information about the nginx-devel mailing list