[PATCH] Configure: remove redundant NGX_OPENSSL_MD5

Piotr Sikora piotrsikora at google.com
Mon Oct 26 21:45:43 UTC 2015


Hey Maxim,

> These macros are destinct.  The NGX_HAVE_OPENSSL_MD5_H means that
> we are using "openssl/md5.h" include.  Second one means that we
> are using OpenSSL-style function names, like "MD5_Init", and not
> RSA-like names like "MD5Init".
>
> Such a distinction may be needed when using external MD5 library
> with --with-md5.

Hmm... Are there any useful external MD5 libraries that use
OpenSSL-style function names?

>> diff -r 7435401242d6 -r 84b550025712 auto/lib/md5/conf
>> --- a/auto/lib/md5/conf
>> +++ b/auto/lib/md5/conf
>> @@ -8,8 +8,7 @@ if [ $MD5 != NONE ]; then
>>      if grep MD5_Init $MD5/md5.h 2>&1 >/dev/null; then
>>          # OpenSSL md5
>>          OPENSSL_MD5=YES
>> -        have=NGX_HAVE_OPENSSL_MD5 . auto/have
>> -        have=NGX_OPENSSL_MD5 . auto/have
>> +        have=NGX_HAVE_OPENSSL_MD5_H . auto/have
>
> I don't think this is a typo, rather it tries to define the
> NGX_HAVE_OPENSSL_MD5 macro, currently unused.  Note that it tests
> "md5.h", not "openssl/md5.h".

Right... Shouldn't the unused macro be removed, then?

Best regards,
Piotr Sikora



More information about the nginx-devel mailing list