[PATCH] Configure: remove redundant NGX_OPENSSL_MD5

[Maxim Dounin]

Hello!

On Mon, Oct 26, 2015 at 02:45:43PM -0700, Piotr Sikora wrote:

> Hey Maxim,
> 
> > These macros are destinct.  The NGX_HAVE_OPENSSL_MD5_H means that
> > we are using "openssl/md5.h" include.  Second one means that we
> > are using OpenSSL-style function names, like "MD5_Init", and not
> > RSA-like names like "MD5Init".
> >
> > Such a distinction may be needed when using external MD5 library
> > with --with-md5.
> 
> Hmm... Are there any useful external MD5 libraries that use
> OpenSSL-style function names?

At least one can be easily found under crypto/md5/ in the OpenSSL 
sources.  Likely recent changes to OpenSSL broke it though. 

(I personally think that --with-md5 and --with-sha1 aren't really 
useful at all, as well as auto/lib/{md5,sha1}.  We have good 
enough internal md5 implementation now (and I have a patch for 
sha1 as well), so there is no real need to use external libraries.  
On the other hand, I don't think that removing --with-md5 and 
--with-sha1 is a good idea either.)


> >> diff -r 7435401242d6 -r 84b550025712 auto/lib/md5/conf
> >> --- a/auto/lib/md5/conf
> >> +++ b/auto/lib/md5/conf
> >> @@ -8,8 +8,7 @@ if [ $MD5 != NONE ]; then
> >>      if grep MD5_Init $MD5/md5.h 2>&1 >/dev/null; then
> >>          # OpenSSL md5
> >>          OPENSSL_MD5=YES
> >> -        have=NGX_HAVE_OPENSSL_MD5 . auto/have
> >> -        have=NGX_OPENSSL_MD5 . auto/have
> >> +        have=NGX_HAVE_OPENSSL_MD5_H . auto/have
> >
> > I don't think this is a typo, rather it tries to define the
> > NGX_HAVE_OPENSSL_MD5 macro, currently unused.  Note that it tests
> > "md5.h", not "openssl/md5.h".
> 
> Right... Shouldn't the unused macro be removed, then?

I don't think it worth the effert, especially considering the fact 
that correct name seems to be NGX_HAVE_OPENSSL_MD5 (broken in 
0.1.9, fixed by introduction of an additional name in 0.1.13).

-- 
Maxim Dounin
http://nginx.org/