[PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

Piotr Sikora piotrsikora at google.com
Sun Apr 9 04:17:26 UTC 2017


Hey Valentin,

> With your patch the behavior is different in these cases:
>
> GET / HTTP/1.1
> Host: example.com
> Transfer-Encoding: chunked
>
> 0
>
> and
>
> HEADERS
> DATA length:0 END_STREAM

That wasn't really the case I was optimizing for, but that's a good point.

> Moreover, it depends on the time when DATA frame is processed:
> before ngx_http_read_request_body() call or after.

Does it? Won't content handlers (and thus
ngx_http_v2_read_request_body()) be always called right after HEADERS
frame is processed?

Anyway, both of your patches work as well, so feel free to commit any of those.

Thanks!

Best regards,
Piotr Sikora


More information about the nginx-devel mailing list