[PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

Valentin V. Bartenev vbart at nginx.com
Sun Apr 9 13:31:39 UTC 2017


On Saturday 08 April 2017 21:17:26 Piotr Sikora via nginx-devel wrote:
> Hey Valentin,
> 
> > With your patch the behavior is different in these cases:
> >
> > GET / HTTP/1.1
> > Host: example.com
> > Transfer-Encoding: chunked
> >
> > 0
> >
> > and
> >
> > HEADERS
> > DATA length:0 END_STREAM
> 
> That wasn't really the case I was optimizing for, but that's a good point.
> 
> > Moreover, it depends on the time when DATA frame is processed:
> > before ngx_http_read_request_body() call or after.
> 
> Does it? Won't content handlers (and thus
> ngx_http_v2_read_request_body()) be always called right after HEADERS
> frame is processed?

Request processing can be delayed (e.g. by the limit_req module).

  wbr, Valentin V. Bartenev



More information about the nginx-devel mailing list