[PATCH] HTTP/2: add debug logging of control frames

[Valentin V. Bartenev]

On Tuesday 30 May 2017 14:21:05 Piotr Sikora via nginx-devel wrote:
> Hey Valentin,
> 
> > What do you suggest instead? All 3 params in the same line?
> >
> >    http2 send SETTINGS frame MAX_CONCURRENT_STREAMS:%ui
> > INITIAL_WINDOW_SIZE:%uz MAX_FRAME_SIZE:%ud
> >
> > What about receiving part, then? Do you want to put all 6 params in
> > the same line?
> >
> >    http2 recv SETTINGS frame HEADER_TABLE_SIZE:%ui (ignored)
> > ENABLE_PUSH:%ui (ignored) MAX_CONCURRENT_STREAMS:%ui (ignored)
> > INITIAL_WINDOW_SIZE:%ui MAX_FRAME_SIZE:%ui MAX_HEADER_LIST_SIZE:%ui
> > (ignored)
> >
> > It makes this way less readable, IMHO.
> 
> Ping.
> 

Ok, I've already resigned myself to multiline output, but don't let it
look like an another SETTINGS frame.

IMHO, something like that will be good enough:

   http2 send SETTINGS frame
   http2 SETTINGS param MAX_CONCURRENT_STREAMS: 100
   http2 SETTINGS param INITIAL_WINDOW_SIZE: 65536
   http2 SETTINGS param MAX_FRAME_SIZE: 16777215


  wbr, Valentin V. Bartenev