[PATCH] HTTP/2: reject HTTP/2 requests without ":scheme" pseudo-header

Valentin V. Bartenev vbart at nginx.com
Tue Mar 28 18:10:51 UTC 2017

On Tuesday 28 March 2017 05:40:44 Piotr Sikora via nginx-devel wrote:
> Hey Valentin,
> > This part of patch can be added to the style one:
> >
> >   "HTTP/2: style and typos."
> Assuming that this patch gets dropped or even if it gets committed?

IMHO it's not a good idea to combine style fixes with behavior changes.
Behavior changing commits are occasionally reverted.

> > Is there any practical reason to force this restriction?
> None, other than following RFC and providing early detection of broken clients.
> Also, it looks that you have a test for it marked as TODO:
> http://hg.nginx.org/nginx-tests/annotate/a6abbfed42c0/h2_headers.t#l972

That's why it's still TODO (in other words intentionally skipped).
We discussed it with QA and decided to be more tolerant here.

  wbr, Valentin V. Bartenev

More information about the nginx-devel mailing list