[PATCH] HTTP/2: reject HTTP/2 requests without ":scheme" pseudo-header

Piotr Sikora piotrsikora at google.com
Thu Mar 30 01:01:55 UTC 2017

Hey Valentin,

> IMHO it's not a good idea to combine style fixes with behavior changes.
> Behavior changing commits are occasionally reverted.

Fair enough, I'll update both patches shortly.

> That's why it's still TODO (in other words intentionally skipped).
> We discussed it with QA and decided to be more tolerant here.

I disagree. Forgiving implementations that allow broken clients to
seemingly "work", even when said clients are not obeying the
specification, are the reason why we have broken clients in the first

Best regards,
Piotr Sikora

More information about the nginx-devel mailing list