[nginx] Stream: relaxed next upstream condition (ticket #1317).

Maxim Dounin mdounin at mdounin.ru
Tue Oct 17 13:06:52 UTC 2017

details:   http://hg.nginx.org/nginx/rev/b9d919b53593
branches:  stable-1.12
changeset: 7142:b9d919b53593
user:      Roman Arutyunyan <arut at nginx.com>
date:      Mon Sep 11 15:32:31 2017 +0300
Stream: relaxed next upstream condition (ticket #1317).

When switching to a next upstream, some buffers could be stuck in the middle
of the filter chain.  A condition existed that raised an error when this
happened.  As it turned out, this condition prevented switching to a next
upstream if ssl preread was used with the TCP protocol (see the ticket).

In fact, the condition does not make sense for TCP, since after successful
connection to an upstream switching to another upstream never happens.  As for
UDP, the issue with stuck buffers is unlikely to happen, but is still possible.
Specifically, if a filter delays sending data to upstream.

The condition can be relaxed to only check the "buffered" bitmask of the
upstream connection.  The new condition is simpler and fixes the ticket issue
as well.  Additionally, the upstream_out chain is now reset for UDP prior to
connecting to a new upstream to prevent repeating the client data twice.


 src/stream/ngx_stream_proxy_module.c |  8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diffs (23 lines):

diff --git a/src/stream/ngx_stream_proxy_module.c b/src/stream/ngx_stream_proxy_module.c
--- a/src/stream/ngx_stream_proxy_module.c
+++ b/src/stream/ngx_stream_proxy_module.c
@@ -1677,13 +1677,17 @@ ngx_stream_proxy_next_upstream(ngx_strea
     u = s->upstream;
     pc = u->peer.connection;
-    if (u->upstream_out || u->upstream_busy || (pc && pc->buffered)) {
+    if (pc && pc->buffered) {
         ngx_log_error(NGX_LOG_ERR, s->connection->log, 0,
-                      "pending buffers on next upstream");
+                      "buffered data on next upstream");
         ngx_stream_proxy_finalize(s, NGX_STREAM_INTERNAL_SERVER_ERROR);
+    if (s->connection->type == SOCK_DGRAM) {
+        u->upstream_out = NULL;
+    }
     if (u->peer.sockaddr) {
         u->peer.free(&u->peer, u->peer.data, NGX_PEER_FAILED);
         u->peer.sockaddr = NULL;

More information about the nginx-devel mailing list