[nginx] OCSP stapling: open ssl_stapling_file in binary-mode.

Sergey Kandaurov pluknet at nginx.com
Wed Apr 3 12:46:08 UTC 2019


details:   https://hg.nginx.org/nginx/rev/edf5cd6c56fa
branches:  
changeset: 7485:edf5cd6c56fa
user:      Sergey Kandaurov <pluknet at nginx.com>
date:      Wed Apr 03 15:35:39 2019 +0300
description:
OCSP stapling: open ssl_stapling_file in binary-mode.

OCSP response uses the DER format and as such needs to be opened in binary-mode.
This only has any effect under Win32.

diffstat:

 src/event/ngx_event_openssl_stapling.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff -r 65074e13f171 -r edf5cd6c56fa src/event/ngx_event_openssl_stapling.c
--- a/src/event/ngx_event_openssl_stapling.c	Tue Mar 26 09:33:57 2019 +0300
+++ b/src/event/ngx_event_openssl_stapling.c	Wed Apr 03 15:35:39 2019 +0300
@@ -227,7 +227,7 @@ ngx_ssl_stapling_file(ngx_conf_t *cf, ng
         return NGX_ERROR;
     }
 
-    bio = BIO_new_file((char *) file->data, "r");
+    bio = BIO_new_file((char *) file->data, "rb");
     if (bio == NULL) {
         ngx_ssl_error(NGX_LOG_EMERG, ssl->log, 0,
                       "BIO_new_file(\"%s\") failed", file->data);


More information about the nginx-devel mailing list