[PATCH 4 of 8] QUIC: removed ngx_quic_shutdown_connection()

Roman Arutyunyan arut at nginx.com
Tue Aug 23 12:28:51 UTC 2022


On Tue, Aug 02, 2022 at 07:44:11PM +0400, Sergey Kandaurov wrote:
> On Thu, Jun 23, 2022 at 07:58:42PM +0400, Roman Arutyunyan wrote:
> > # HG changeset patch
> > # User Roman Arutyunyan <arut at nginx.com>
> > # Date 1655904279 -14400
> > #      Wed Jun 22 17:24:39 2022 +0400
> > # Branch quic
> > # Node ID 1912c09e0e4d746ec0a4c2140b6d2046b283b647
> > # Parent  ea555f7caec372e93e1b9a11ed822002e97ed58b
> > QUIC: removed ngx_quic_shutdown_connection().
> > 
> > HTTP/3 shutdown is now controlled by HTTP/3 layer.  QUIC connection is
> > finalized after reaching requests limit when all request streams have finished.
> 
> Finalizing QUIC connection from HTTP/3 connection cleanup handler
> prevents the last stream cleanup handler from regular run.  Normally
> it is called next, but after QUIC shutdown initiated, that's too late,
> and stream FIN won't be sent.

Looks like moving shutdown out of QUIC to HTTP/3 is not so easy.  Let's give
up this idea.  I've reworked the patchset a little bit.



More information about the nginx-devel mailing list