Fixed gzip_disable_degradation defined without NGX_HTTP_DEGRADATION (broken by 3b522d7a5b34).

Maxim Dounin mdounin at
Sun Dec 4 20:09:31 UTC 2022


On Sat, Dec 03, 2022 at 11:16:44PM +0800, 杜叶飞(淮叶) via nginx-devel wrote:

> I think gzip_disable_degradation needs NGX_HTTP_DEGRADATION in order to be consistent with where used. 
> details: < >

The revision you've linked explains why this "#if" is not really 
needed even if we are concerned about saving these two bits in the 
location configuration structure (and we aren't really concerned 

Further, the patch you've suggested breaks binary compatibility 
between nginx builds with and without the degradation module 
without restoring appropriate flag in the binary signature.  This 
is clearly incorrect behaviour which can result in segmentation 
faults or other unexpected behaviour if modules compiled with 
different assumptions are loaded into nginx.

Maxim Dounin

More information about the nginx-devel mailing list