[PATCH] Events: fixed style and wrong error handling in the iocp module

Sergey Kandaurov pluknet at nginx.com
Tue Sep 6 11:49:19 UTC 2022


> On 26 Aug 2022, at 05:17, Maxim Dounin <mdounin at mdounin.ru> wrote:
> 
> # HG changeset patch
> # User Maxim Dounin <mdounin at mdounin.ru>
> # Date 1661476617 -10800
> #      Fri Aug 26 04:16:57 2022 +0300
> # Node ID 3296b3825fa9b8cd4d0aafb39bb5ea1fac97c6db
> # Parent  069a4813e8d6d7ec662d282a10f5f7062ebd817f
> Events: fixed style and wrong error handling in the iocp module.
> 
> diff --git a/src/event/modules/ngx_iocp_module.c b/src/event/modules/ngx_iocp_module.c
> --- a/src/event/modules/ngx_iocp_module.c
> +++ b/src/event/modules/ngx_iocp_module.c
> @@ -231,9 +231,8 @@ ngx_iocp_del_connection(ngx_connection_t
> }
> 
> 
> -static
> -ngx_int_t ngx_iocp_process_events(ngx_cycle_t *cycle, ngx_msec_t timer,
> -    ngx_uint_t flags)
> +static ngx_int_t
> +ngx_iocp_process_events(ngx_cycle_t *cycle, ngx_msec_t timer, ngx_uint_t flags)
> {
>     int                rc;
>     u_int              key;
> @@ -356,7 +355,7 @@ ngx_iocp_create_conf(ngx_cycle_t *cycle)
> 
>     cf = ngx_palloc(cycle->pool, sizeof(ngx_iocp_conf_t));
>     if (cf == NULL) {
> -        return NGX_CONF_ERROR;
> +        return NULL;
>     }
> 
>     cf->threads = NGX_CONF_UNSET;

Looks good.

-- 
Sergey Kandaurov



More information about the nginx-devel mailing list