.5 upgrade errors

[Igor Sysoev]

On Sun, 10 Dec 2006, Jonathan Vanasco wrote:

> i just upped to .5 (using freebsd port), and have been finding a bunch of 
> errors/bugs.
>
> 	access_log
> 		'off' no longer turns the access log off.  it now logs to a 
> file named off (relative to nginx config file / root )
> 		i seem to be getting access_log and  debug (error log) 
> information there.  i'm not quite sure  what  is going on.

How does access_log directive look ?
It's strange - I use 0.5.0 on one production site with lot of
"access_log off"s.

> 	proxy
> 		if i have a fastcgi proxy defined all proxy pass directives 
> seem to go that ip/port
> 		whats very odd, is that php is  set to spawn to 8888
> 		location ~ .php$ {
> 		        fastcgi_pass   127.0.0.1:8888;location ~ .php$ {
>        		fastcgi_pass   127.0.0.1:8888;
> 		}
> 		if that match is  active at all in the nginx config, all 
> proxy passes go to 127.0.0.1:8888
> 				location / {
> 			proxy_pass   http://127.0.0.1:8022;
> 		}
> 		will go to 127.0.0.1:8888 and cause an error
>
> 		mod_proxy seems to not work at all otherwise.

The attached patch should fix the bug.

> there are a bunch more  errors, but that seems to be the ones i can figure 
> out the most about
>
> i can't figure out if this is specific to the FreeBSD port or nginx in 
> general.
> In any case, if you are on FreeBSD, I STRONGLY suggest sticking to .4.14
>
> also: it would be nice if there were a way to do a debug level for mapping 
> only.  apache and lighttpd both support this.
> 	ie:
> 		request uri = x
> 		try patterns y
> 		matched to z
> 		nginx has this support, but  there seems no way to isolate it

Do you mean "rewrite_log  on" ? It logs at "notice" level.


Igor Sysoev
http://sysoev.ru/en/
-------------- next part --------------
Index: src/http/ngx_http_upstream.c
===================================================================
--- src/http/ngx_http_upstream.c	(revision 212)
+++ src/http/ngx_http_upstream.c	(working copy)
@@ -2843,7 +2843,8 @@
     uscfp = umcf->upstreams.elts;
 
     for (i = 0; i < umcf->upstreams.nelts; i++) {
-        if (uscfp[i]->host.len != u->host.len
+        if (uscfp[i]->port != u->portn
+            || uscfp[i]->host.len != u->host.len
             || ngx_strncasecmp(uscfp[i]->host.data, u->host.data, u->host.len)
                != 0)
         {