SSL not initialized properly in a server section containing a syntax error in the server_name directive

[Igor Sysoev]

On Fri, Jun 27, 2008 at 09:32:24AM -0400, Just Marc wrote:

> >nginx treats this as
> >
> >    server_name hostname.com  ssl  on;
> >
> >The problem is that "ssl" and "on" may be valid server names.
> >
> >The server_name directive now checks only "/" symbols in name and
> >issues warning
> >
> >      server name "..." has strange symbols
> >
> >to prevent
> >
> >    server_name hostname.com
> >    access_log  /path/to/log;
> >
> >and so.
> >  
> 
> Maybe we should have a bit that says which directives are allowed to 
> span multiple lines?

Any directives:

    location
    /
    {
    root
    /path/to/root
    ;
    }

> This doesn't feel robust enough now.

Yes, anything has its trade offs.


-- 
Igor Sysoev
http://sysoev.ru/en/