gzip_disable and vary header

[Spil Games]

Hi,

A while ago we were having some troubles with gzip and old IE6. I then
found this blog entry which seemed to solve my troubles:

http://robsanheim.com/2008/02/07/beware-the-default-nginx-config-old-ie6-hates-gzip/


However immediately after applying this fix to our Nginx config files I
realised that there was still something wrong. If gzip_disable acts on
the User-Agent to enable/disable compression, shouldn't gzip_vary act on
this too? In other words shouldn't it send this header?:

Vary: Accept-Encoding, User-Agent


Attached patch modifies Nginx 0.6 to send above header when both
gzip_vary and gzip_disable are being used. It reverts back to the old
behaviour of sending only Accept-Encoding in the Vary header if
gzip_disable is not in use.

Feedback appreciated.


Regards,

Matthijs van der Klip

Attachments:
http://www.ruby-forum.com/attachment/3541/nginx-0.6.35-gzip_vary.patch

-- 
Posted via http://www.ruby-forum.com/.