Openresty downstream bundle maintenance requests

[Nginx User]

On Sat, Sep 17, 2011 at 6:42 PM, Nginx User <nginx at nginxuser.net> wrote:

>
>
> On Sat, Sep 17, 2011 at 6:22 PM, agentzh <agentzh at gmail.com> wrote:
>
>> On Sat, Sep 17, 2011 at 10:43 PM, Nginx User <nginx at nginxuser.net> wrote:
>> >>
>> >> These options should be happily accepted by the last 2nd option. If
>> >> not, please let me know :)
>> >
>> >
>> > They are matched by the last option of 'die "Invalid option $opt\n";' .
>> >
>>
>> I've just confirmed that at least "--includedir=PATH" and
>> "--datadir=PATH" are accepted by ngx_openresty's configure script but
>> rejected by nginx's configure script:
>>
>>    ~/work/nginx-1.0.6 $ ./configure --includedir=/tmp/blah
>>    ./configure: error: invalid option "--includedir=/tmp/blah"
>>
>>    ~/work/nginx-1.0.6 $ ./configure --datadir=/tmp/blah
>>    ./configure: error: invalid option "--datadir=/tmp/blah"
>>
>> Please note that the 'error: invalid option ".*"' messages
>> *different* from the one output by 'die "Invalid option $opt\n";'.
>>
>> Regards,
>> -agentzh
>>
>
> Nginx configure script has to be patched for rpm build environment.
> Below is the standard patch used.
>
> --- auto/cc/gcc.orig 2007-03-22 08:34:53.000000000 -0600
> +++ auto/cc/gcc 2007-03-22 08:58:47.000000000 -0600
> @@ -172,7 +172,9 @@
>
>
>  # stop on warning
> -CFLAGS="$CFLAGS -Werror"
> +# This combined with Fedora's FORTIFY_SOURCE=2 option causes it nginx
> +# to not compile.
> +#CFLAGS="$CFLAGS -Werror"
>
>  # debug
>  CFLAGS="$CFLAGS -g"
>
>
> The standard outputs from the rpm %configure macro including all those
> elements build fine after this when building nginx by itself. An example of
> the typical spec file with this patch is
> http://www4.atomicorp.com/channels/source/nginx/nginx.spec (they are not
> up to date but it does work as is for 1.0.6 and should for the 1.1.x branch
> as well.
>
> However things crash with the openresty configure as said. Specifically,
> the message returned is for on "--build" which is the first one encountered.
> Recreating the build machine at the moment so can't give specifics right
> now. I'll try changing the text in 'die "Invalid option $opt\n";' when
> having another go to verify whether it is actually this or not. Looking at
> the code though, it seems clear that these extra options will fail at the
> specified point.
>
> Thanks.
>


Hi.

Just looking at the spec file example I linked to, I can see it is not using
the rpm %configure macro.  So you were on to something there.

I suppose the only remaining valid request from my original post is the lua
one.

Thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.nginx.org/pipermail/nginx/attachments/20110917/bb625ccc/attachment-0001.html>