Openresty downstream bundle maintenance requests

[agentzh]

On Sat, Sep 17, 2011 at 11:42 PM, Nginx User <nginx at nginxuser.net> wrote:
> Nginx configure script has to be patched for rpm build environment.
> Below is the standard patch used.
>
> --- auto/cc/gcc.orig 2007-03-22 08:34:53.000000000 -0600
> +++ auto/cc/gcc 2007-03-22 08:58:47.000000000 -0600
> @@ -172,7 +172,9 @@
>
>
>  # stop on warning
> -CFLAGS="$CFLAGS -Werror"
> +# This combined with Fedora's FORTIFY_SOURCE=2 option causes it nginx
> +# to not compile.
> +#CFLAGS="$CFLAGS -Werror"
>
>  # debug
>  CFLAGS="$CFLAGS -g"
>

The nginx core bundled by ngx_openresty has this patch as well.

> The standard outputs from the rpm %configure macro including all those
> elements build fine after this when building nginx by itself. An example of
> the typical spec file with this patch
> is http://www4.atomicorp.com/channels/source/nginx/nginx.spec (they are not
> up to date but it does work as is for 1.0.6 and should for the 1.1.x branch
> as well.
> However things crash with the openresty configure as said. Specifically, the
> message returned is for on "--build" which is the first one encountered.

The configure command in the RPM spec file you link to does not crash
on my slackware linux x86_64 for ngx_openresty 1.0.6.5. I wonder what
error messages are you getting?

> Recreating the build machine at the moment so can't give specifics right
> now. I'll try changing the text in 'die "Invalid option $opt\n";' when
> having another go to verify whether it is actually this or not. Looking at
> the code though, it seems clear that these extra options will fail at the
> specified point.

Why won't "--build" be matched by /^--\w.*/ in ngx_openresty's
configure script? I've said extra options would be captured by the
last 2nd condition and be passed verbatim to nginx's configure script
and would not reach the last "die" statement there.

Regards,
-agentzh