potential null dereference

[B.R.]

If you think you spot a bug, You'd better open a ticket on Trac
<https://trac.nginx.org/>.

You could also talk about development matters on the nginx-devel
<http://mailman.nginx.org/mailman/listinfo/nginx-devel> Mailling List. This
is the 'users' ML, centered on use cases/configuration/help
with/discussions around the software.
---
*B. R.*

On Thu, Feb 16, 2017 at 4:59 AM, alexc at sbrella.com <alexc at sbrella.com>
wrote:

> Hi，
>
> In file /src/http/ngx_http_upstream.c, function
> ngx_http_upstream_finalize_request
>
>
> // if u->pipe == NULL, ngx_http_file_cache_free(r->cache,
> u->pipe->temp_file); will dereference a null pointer, it's that right ?
>
> // Regards
> // Alex
>
> if (u->store && u->pipe && u->pipe->temp_file
>         && u->pipe->temp_file->file.fd != NGX_INVALID_FILE)
>     {
>         if (ngx_delete_file(u->pipe->temp_file->file.name.data)
>             == NGX_FILE_ERROR)
>         {
>             ngx_log_error(NGX_LOG_CRIT, r->connection->log, ngx_errno,
>                           ngx_delete_file_n " \"%s\" failed",
>                           u->pipe->temp_file->file.name.data);
>         }
>     }
>
> #if (NGX_HTTP_CACHE)
>
>     if (r->cache) {
>
>       ......
>
>         ngx_http_file_cache_free(r->cache, u->pipe->temp_file);
>     }
>
>
> ------------------------------
> alexc at sbrella.com
>
> _______________________________________________
> nginx mailing list
> nginx at nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.nginx.org/pipermail/nginx/attachments/20170216/42a5b008/attachment.html>