[PATCH v4 06/12] test_static.py: formatting fix

[Alejandro Colomar (man-pages)]

Hi Andrei,

On 1/27/22 14:14, Andrei Zeliankou wrote:
> Hi!
> 
>> On 23 Dec 2021, at 19:25, Alejandro Colomar <alx.manpages at gmail.com> wrote:
>>
>> Expand indentation, to allow for the addition of an "index"
>> configuration.  This only changes whitespace/indentation.
> 
> 
> There is no need to move changes like this into the separate patch.

I know, but then patch 07 becomes easier to read[1], IMO.  While writing
this feature, I found some patches that contained a bit more than what
they stated, probably because a separate patch for those minor changes
would be too much; but then the patch became a bit less readable.  If
you're okay with this separation, I tend to prefer smaller patches.

Thanks,

Alex


[1]:

@@ -32,7 +32,8 @@ class TestStatic(TestApplicationProto):
                 "routes": [
                     {
                         "action": {
-                            "share": option.temp_dir + "/assets$uri"
+                            "share": option.temp_dir + "/assets$uri",
+                            "index": "index_.html"
                         }
                     }
                 ],

> 
>>
>> Signed-off-by: Alejandro Colomar <alx.manpages at gmail.com>
>> Cc: Nginx Unit <unit at nginx.org>
>> Cc: "Valentin V. Bartenev" <vbart at nginx.com>
>> Cc: Zhidao HONG <z.hong at f5.com>
>> Cc: Igor Sysoev <igor at sysoev.ru>
>> Cc: Oisin Canty <o.canty at f5.com>
>> ---
>> test/test_static.py | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/test/test_static.py b/test/test_static.py
>> index 80f4c61..76668a1 100644
>> --- a/test/test_static.py
>> +++ b/test/test_static.py
>> @@ -30,7 +30,11 @@ class TestStatic(TestApplicationProto):
>>             {
>>                 "listeners": {"*:7080": {"pass": "routes"}},
>>                 "routes": [
>> -                    {"action": {"share": option.temp_dir + "/assets$uri"}}
>> +                    {
>> +                        "action": {
>> +                            "share": option.temp_dir + "/assets$uri"
>> +                        }
>> +                    }
>>                 ],
>>                 "settings": {
>>                     "http": {
>> -- 
>> 2.34.1
>>
>> _______________________________________________
>> unit mailing list
>> unit at nginx.org
>> https://mailman.nginx.org/mailman/listinfo/unit
> 

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/