[PATCH 09/11] Router: removed unused structure member proxy_buffers.

Andrew Clayton andrew at digital-domain.net
Thu Jun 16 18:03:08 UTC 2022


On Thu, 16 Jun 2022 17:59:25 +0200
Alejandro Colomar <alx.manpages at gmail.com> wrote:

> On 6/16/22 03:00, Andrew Clayton wrote:
> > proxy_buffers is declared as a structure member of nxt_socket_conf_t and
> > is set in nxt_router_conf_create(), however it is not used anywhere.
> > 
> > Removing it has the nice side effect of making the nxt_socket_conf_t
> > structure require one less cacheline (on x86-64 at least) as the summary
> > from pahole[0] shows
> > 
> > Before
> > 
> >      /* size: 200, cachelines: 4, members: 25 */
> >      /* sum members: 185, holes: 3, sum holes: 15 */
> > 
> > After
> > 
> >      /* size: 192, cachelines: 3, members: 24 */
> >      /* sum members: 177, holes: 3, sum holes: 15 */
> > 
> > [0]: https://github.com/acmel/dwarves  
> 
> Reviewed-by: Alejandro Colomar <alx.manpages at gmail.com>

Thanks!

Cheers,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.nginx.org/pipermail/unit/attachments/20220616/8c921dc2/attachment.bin>


More information about the unit mailing list