[PATCH 09/11] Router: removed unused structure member proxy_buffers.

[Alejandro Colomar]

Hi Andrew,

On 6/16/22 20:03, Andrew Clayton wrote:
> On Thu, 16 Jun 2022 17:59:25 +0200
> Alejandro Colomar <alx.manpages at gmail.com> wrote:
> 
>> On 6/16/22 03:00, Andrew Clayton wrote:
>>> proxy_buffers is declared as a structure member of nxt_socket_conf_t and
>>> is set in nxt_router_conf_create(), however it is not used anywhere.
>>>
>>> Removing it has the nice side effect of making the nxt_socket_conf_t
>>> structure require one less cacheline (on x86-64 at least) as the summary
>>> from pahole[0] shows
>>>
>>> Before
>>>
>>>       /* size: 200, cachelines: 4, members: 25 */
>>>       /* sum members: 185, holes: 3, sum holes: 15 */
>>>
>>> After
>>>
>>>       /* size: 192, cachelines: 3, members: 24 */
>>>       /* sum members: 177, holes: 3, sum holes: 15 */
>>>
>>> [0]: https://github.com/acmel/dwarves
>>
>> Reviewed-by: Alejandro Colomar <alx.manpages at gmail.com>

I run this patch under the build bot 2 times, one of them triggered 
errors I hadn't seen before, and the other went well.  That looks like 
undefined behavior somewhere (I'm attributing it to this patch because 
it's the only one from the reviewed ones that actually changes something 
that's not compile-time-only); I'm not saying that it's a problem of 
this patch; it could be that this change triggers another UB that was 
already existing but hidden).  So I'm not applying this patch until we 
know more about it. :/

Cheers,

Alex

> 
> Thanks!
> 
> Cheers,
> Andrew

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.nginx.org/pipermail/unit/attachments/20220622/09852bfd/attachment.bin>