[PATCH] Stream pass: disabled passing from or to udp

Roman Arutyunyan arut at nginx.com
Fri May 3 16:30:53 UTC 2024


Hi,

On Fri, May 03, 2024 at 08:24:16PM +0400, Sergey Kandaurov wrote:
> 
> > On 26 Apr 2024, at 15:15, Roman Arutyunyan <arut at nginx.com> wrote:
> > 
> > # HG changeset patch
> > # User Roman Arutyunyan <arut at nginx.com>
> > # Date 1714057362 -14400
> > #      Thu Apr 25 19:02:42 2024 +0400
> > # Branch stable-1.26
> 
> wrong branch

Yes, already noticed this.

> > # Node ID a60cd9c99efcc1204e6d395104beb39883308c93
> > # Parent  cdf74ac25b47ec928b53aa82ccc1c3d288a2f81c
> > Stream pass: disabled passing from or to udp.
> > 
> > Passing from udp was not possible for the most part due to preread buffer
> > restriction.  Passing to udp could occasionally work, but the connection would
> > still be bound to the orignial listen rbtree, which prevented it from being
> 
> typo in "original"

Thanks.

> > deleted on connection closure.
> > 
> > Also, passing to a QUIC listen socket is disabled by this change as well.
> 
> disabled for the same reasons?

Let's just remove this part.  I think no explanation is needed in this
version of the patch.

Final version:

Stream pass: disabled passing from or to udp.

Passing from udp was not possible for the most part due to preread buffer
restriction.  Passing to udp could occasionally work, but the connection would
still be bound to the original listen rbtree, which prevented it from being
deleted on connection closure.

[..]

--
Roman Arutyunyan


More information about the nginx-devel mailing list