[PATCH v3 12/12] Static: multiple paths in the "index" option

Alejandro Colomar (man-pages) alx.manpages at gmail.com
Sun Dec 19 11:39:29 UTC 2021

Hi Valentin,

On 12/19/21 04:11, Valentin V. Bartenev wrote:
> On Sunday, 19 December 2021 04:30:30 MSK Alejandro Colomar wrote:
> [..]
>> @@ -242,6 +254,7 @@ nxt_http_static_iterate(nxt_task_t *task, nxt_http_request_t *r,
>>       conf = ctx->action->u.conf;
>>       share = &conf->shares[ctx->share_idx];
>> +    index = conf->indices[ctx->index_idx];
>>   #if (NXT_DEBUG)
>>       nxt_str_t  shr;
> [..]
> I haven't applied and tested this patch yet, but are you sure that it works?
> Because from just a brief look I don't see where ctx->index_idx is incremented.

You're right.  It doesn't work.  Patch [12/12] is still a work in 
progress.  I should have mentioned that in the commit message in this 
patch, instead of just mentioning it in the overview of the patch set. 
Instead, the commit message was misleading, since I wrote there what 
this commit should do when it's finished, instead of what it's doing 
right now.

> Am I missing somehting?

I explained it in the cover letter of this patch set revision:
which is patch [v3 00/12]:

On 12/19/21 02:30, Alejandro Colomar wrote:
 > For this review of the patch set, I didn't yet do much testing.  I
 > passed all previously existing pytests.  The only one that fails
 > is the one I modified in patch 12 (the last one), which is to be
 > expected, since I didn't yet write code to iterate over the
 > indices (it's just picking the first element in the array always).
 > If you reverse the order in the array (in the pytest) to be
 > 	["$host.html", "idontexist"]
 > it passes the test, which at least makes me happy since the
 > part that should still work (compared to step 2) still works.

I assumed you were familiar with what git calls a cover letter.

            In addition to the patches, generate a cover letter
            file containing the branch description, shortlog and
            the overall diffstat. You can fill in a description
            in the file before sending it out.

Git numbers patches starting from 1, and then there's an optional patch 
0, controlled by --cover-letter, which is the first email in the thread, 
and gives an overview of the patch set.


Alejandro Colomar
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/

More information about the unit mailing list