[PATCH v3 12/12] Static: multiple paths in the "index" option

Valentin V. Bartenev vbart at nginx.com
Sun Dec 19 15:22:01 UTC 2021


On Sunday, 19 December 2021 14:39:29 MSK Alejandro Colomar (man-pages) wrote:
> Hi Valentin,
> 
> On 12/19/21 04:11, Valentin V. Bartenev wrote:
> > On Sunday, 19 December 2021 04:30:30 MSK Alejandro Colomar wrote:
> > [..]
> >> @@ -242,6 +254,7 @@ nxt_http_static_iterate(nxt_task_t *task, nxt_http_request_t *r,
> >>       conf = ctx->action->u.conf;
> >>   
> >>       share = &conf->shares[ctx->share_idx];
> >> +    index = conf->indices[ctx->index_idx];
> >>   
> >>   #if (NXT_DEBUG)
> >>       nxt_str_t  shr;
> > [..]
> > 
> > I haven't applied and tested this patch yet, but are you sure that it works?
> > Because from just a brief look I don't see where ctx->index_idx is incremented.
> 
> You're right.  It doesn't work.  Patch [12/12] is still a work in 
> progress.  I should have mentioned that in the commit message in this 
> patch, instead of just mentioning it in the overview of the patch set. 
> Instead, the commit message was misleading, since I wrote there what 
> this commit should do when it's finished, instead of what it's doing 
> right now.
> 
> > Am I missing somehting?
> 
> I explained it in the cover letter of this patch set revision:
> <https://mailman.nginx.org/pipermail/unit/2021-December/000304.html>, 
> which is patch [v3 00/12]:

Oh.. ok, I've missed that letter at the first look.
Will reply to it then.

--
Valentin





More information about the unit mailing list